Conversation
edmundmiller
force-pushed
the
failed_job
branch
from
974f6de to
fd76091
Compare
edmundmiller
force-pushed
the
failed_job
branch
from
fd76091 to
44b87b1
Compare
FloWuenne
requested changes
Feb 25, 2025
nextflow.config
Outdated
| @@ -30,6 +30,7 @@ params { | |||
| // Benchmark report options | |||
| generate_benchmark_report = false | |||
Contributor
There was a problem hiding this comment.
Suggested change
| generate_benchmark_report = false | |
| generate_benchmark_report = false |
FloWuenne
requested changes
Feb 25, 2025
Contributor
FloWuenne
left a comment
FloWuenne
left a comment
There was a problem hiding this comment.
A few changes. Mainly have to add the params.remove_failed_tasks to the proper location, which I couldn't add as a suggestion.
FloWuenne
requested changes
Feb 25, 2025
Contributor
FloWuenne
left a comment
FloWuenne
left a comment
There was a problem hiding this comment.
Just incorporate changes and make sure to add params.remove_failed_tasks to proper location!
edmundmiller
force-pushed
the
failed_job
branch
from
44b87b1 to
2d9dcc9
Compare
FloWuenne
approved these changes
Feb 26, 2025
Contributor
|
I think we can ignore the nfvalidation related tests as it's for the old nf-validation plugin, so It'll be dealt with in the TEMPLATE update |
maxulysse
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #74
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).